This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Add windows/hunter support #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be good to go on Windows/Linux (tested with Windows 10 and Ubuntu 16.04). I only tested with as I don't have an environment setup for testing without it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hunter is a cmake package handler (https://github.com/ruslo/hunter), this PR includes support for
boost
Eigen
glog
gflags
Ceres
all others are ignored for the moment but can be added. The PR does not completely compile on Linux or Windows (don't have a mac to test on, assuming mac is supported) as folly is missing. I have another PR I am going to add that removes the dependence on folly mainly for Windows builds. I am thinking I may have to submit them together, but I at least wanted to get a discussion started.